Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed return type annotation for WSMessage.json() #3720

Merged
merged 2 commits into from
May 6, 2019

Conversation

fa1l
Copy link
Contributor

@fa1l fa1l commented Apr 30, 2019

What do these changes do?

Fixed return type annotation for WSMessage.json()

Are there changes in behavior for the user?

No

Related issue number

#3707

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@fa1l fa1l requested review from asvetlov and webknjaz as code owners April 30, 2019 08:36
@codecov-io
Copy link

Codecov Report

Merging #3720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3720   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          43       43           
  Lines        8559     8559           
  Branches     1377     1377           
=======================================
  Hits         8378     8378           
  Misses         75       75           
  Partials      106      106
Impacted Files Coverage Δ
aiohttp/http_websocket.py 98.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9504fe2...5c50797. Read the comment docs.

@asvetlov asvetlov merged commit ad2c187 into aio-libs:master May 6, 2019
@asvetlov
Copy link
Member

asvetlov commented May 6, 2019

Thanks!

asvetlov pushed a commit that referenced this pull request May 6, 2019
asvetlov added a commit that referenced this pull request May 8, 2019
@lock lock bot added the outdated label May 5, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants